Skip to content

Conversation

dugenkui03
Copy link
Contributor

This PR supports custom HandlerMethodArgumentResolver. #259

The implementation refers to spring-framework: mvc/method/annotation/RequestMappingHandlerAdapter.java

Copy link

@chenyhd chenyhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part seems to duplicate

this.validator = HandlerMethodInputValidatorFactory.create(obtainApplicationContext());
}

if (beanValidationPresent) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part seems to duplicate

@rstoyanchev rstoyanchev changed the title Support custom handler method argument resolver Support custom argument resolvers for @SchemaMapping methods Oct 24, 2022
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 24, 2022
@rstoyanchev rstoyanchev added this to the 1.1 Backlog milestone Oct 24, 2022
@LowLevelSubmarine
Copy link

Will this be merged eventually?

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Mar 8, 2023

This is now scheduled for 1.2. However, as the code base has evolved a bit, and I plan to have a look at opportunities for polishing and refactoring related to argument resolvers, I'll close this. Thanks for the pull request in any case @dugenkui03!

@rstoyanchev rstoyanchev closed this Mar 8, 2023
@rstoyanchev
Copy link
Contributor

This is now superseded by #603 if interested to subscribe.

@rstoyanchev rstoyanchev removed this from the 1.x Backlog milestone Mar 8, 2023
@rstoyanchev rstoyanchev added the status: superseded Issue is superseded by another label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded Issue is superseded by another type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants